⤵️ Local download links #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rowanc1
commented
Jun 28, 2023
Comment on lines
+101
to
+106
| if ((link as any).static) { | ||
| // TODO: remove hash | ||
| const urlPath = await resolver.resolveUrl(href); | ||
| const url = await resolver.getDownloadUrl(urlPath); | ||
| (link as any).urlSource = href; | ||
| link.url = url; |
There was a problem hiding this comment.
This is now an async function, and if the link is static we update the URL directly, otherwise we let Jupyter take care of it in the renderer.
agoose77
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to allow for download links.
See #158